--what's your source of electricity going to be? You need it for pumps/filters at least. Chances are you are going to want some lights around it both for esthetic and safety reasons so nobody walks into it by accident in the dark. Solar lights are much cheaper than they used to be but still have to be replaced every couple of years. Similar style lights with permanent wiring are cheaper in the long run but still require power. Figure these into the design before you turn the first shovel of dirt.
--Plants grow. Put in whatever you like but keep in mind that after a couple of months, much less a couple of years, you will be spending more time pulling out excess than worrying about shortages. Surplus water plants make excellent compost after they are chopped up a bit.
--Predators. Raccoons, snakes and birds, primarily herons, will rip through your livestock in short order. Some thoughts to defenses might be in order.
--Leaves. These will endeavor to fill up the pond to the brim every fall. Scooping them out, without wreaking havoc on your "good" plants, is a challenge. One solution is to get one of those big nets they sell to drape over fruit trees to keep birds from eating the produce. Put it on before you think you need to.
--Unwanted chemicals. Anybody in the neighborhood use a lawn service, Terminix or similar? Those chemicals travel in the wind. Chances are you would be fine but if anybody really nearby gets sprayed on a regular basis you might want to keep a tarp handy to throw over the pond for the days this work is being done.
--Permanence. This is most likely going to be around for a LONG time, but the day may come when for one reason or another you don't want it any more. Then you are faced with having to find dirt to fill it in. Solution--one I wish I had used--is to use the dirt to build up a berm around the edge of the hole rather than hauling it off and leaving the water level with the ground. Since you are not going to have fish over winter the loss of insulation is not a factor. This will be unstable and prone to slides until grass or other plantings grow up on it, but it's a possibility to consider. After that it will look terrific. You can use rocks, wood or other materials to brace it and can also build one section of it higher than the rest and base your waterfall there.
--Harvest/intaking. How are you planning to capture the fish in the fall to bring them indoors? You will nearly have to take out all the plants, including the lilies which will be a challenge as their roots become large in a short time and also intertwine with each other. Even with that obstacle removed they are going to be tricky to catch. Do you have a potential market if they breed heavily? That could be a whole lotta fish goin' on there.