Yes, the salt should indeed take care of the ich. Fin rot should heal on it's own with clean water, though Melafix wouldn't hurt.
The problem with BBG information on the web is that a lot of it is outdated and wrong, and then spread even further by hearsay and websites with generic fish profiles. They do equally well in either freshwater or brackish, and each does have it's own advantages - the former allows for a much larger selection of tankmates and plants, and the latter serves as a natural buffer and kills off ich, planaria and leeches that are associated with freshwater.